Skip to content

tensorboard v2 compat; closes #359 #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2019
Merged

tensorboard v2 compat; closes #359 #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions R/tensorboard.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,19 +139,31 @@ tensorboard <- function(log_dir, action = c("start", "stop"),
}
}


tensorboard_version <- function() {
if (is.null(ver <- .globals$tensorboard_version)) {
ver <- package_version(system("tensorboard --version_tb", intern = TRUE))
.globals$tensorboard_version <- ver
}
ver
}


launch_tensorboard <- function(log_dir, host, port, explicit_port, reload_interval, purge_orphaned_data) {

# check for names and provide defaults
names <- names(log_dir)
if (is.null(names))
names <- basename(log_dir)
if (tensorboard_version() < "2.0") {
# check for names and provide defaults
names <- names(log_dir)
if (is.null(names))
names <- basename(log_dir)

# concatenate names if we have them
if (!is.null(names))
log_dir <- paste0(names, ":", log_dir)
# concatenate names if we have them
if (!is.null(names))
log_dir <- paste0(names, ":", log_dir)

# build log_dir
log_dir <- paste(log_dir, collapse = ",")
# build log_dir
log_dir <- paste(log_dir, collapse = ",")
}

# start the process
p <- processx::process$new("tensorboard",
Expand Down