Skip to content

Conversation

@Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Feb 22, 2021

What does this implement/fix?

kernel 5.xでもビルドできることを確認できるようにテストケースを増やしました。
また、GCCのバージョンがOSごとにそれぞれ以下のように変わっているので、GCCのバージョンを指定できるようにしました。

Jessie: GCC 4.8
Strech: GCC 6.3
Buster: GCC 8.3

主な変更は以下の通りです。

  • .github/workflows/driver-cross-build.ymlを更新
  • kernel configを追加
  • 手動でテストを実行するためのスクリプトを追加(GitHub Actionsのテスト内容とほぼ同等)
  • クロスビルド時のログを必要最低限にするためにMakefile.crosscompileを修正

Does this close any currently open issues?

しません。

How has this been tested?

手元でGCCのぞれぞれのバージョンについてtest.shを実行できることを確認しています。

Any other comments?

kernel 5.10では以下のコミットで後方互換性が失われているので、ビルドでエラーが出ます。
これは別PRにて修正します。
raspberrypi/linux@390fd04 (i2c: remove deprecated i2c_new_device API)
raspberrypi/linux@4bdc0d6 (remove ioremap_nocache and devm_ioremap_nocache)

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@Tiryoh Tiryoh added Type: CI Changes to CI configuration files and scripts Type: Testing Adding missing tests or correcting existing tests labels Feb 22, 2021
@Tiryoh Tiryoh marked this pull request as draft February 22, 2021 04:51
@Tiryoh Tiryoh changed the title Add build test for kernel 5.x Add build test for kernel 4.19, 5.4, 5.10 Feb 22, 2021
@Tiryoh Tiryoh changed the title Add build test for kernel 4.19, 5.4, 5.10 Add build test for kernel 5.4, 5.10 Feb 22, 2021
@Tiryoh Tiryoh requested a review from ShotaAk February 24, 2021 04:13
@Tiryoh Tiryoh marked this pull request as ready for review February 24, 2021 04:13
@Tiryoh Tiryoh marked this pull request as draft April 5, 2021 09:20
@Tiryoh Tiryoh marked this pull request as ready for review April 6, 2021 05:50
@Tiryoh Tiryoh requested a review from ShotaAk April 6, 2021 05:50
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います。マージします

@ShotaAk ShotaAk merged commit 28b78c1 into master Apr 8, 2021
@ShotaAk ShotaAk deleted the ci/update-build-test branch April 8, 2021 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: CI Changes to CI configuration files and scripts Type: Testing Adding missing tests or correcting existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants