Skip to content

fix: add opt-out for embedding model download#25

Merged
pszymkowiak merged 1 commit intomainfrom
fix/embedding-opt-out
Mar 16, 2026
Merged

fix: add opt-out for embedding model download#25
pszymkowiak merged 1 commit intomainfrom
fix/embedding-opt-out

Conversation

@pszymkowiak
Copy link
Copy Markdown
Contributor

Summary

  • Add 3 ways to disable embeddings entirely (skip model download at startup):
    • Config: [embeddings] enabled = false
    • CLI flag: icm --no-embeddings <command>
    • Env var: ICM_NO_EMBEDDINGS=1
  • When disabled, ICM falls back to FTS5 keyword search (still functional, no semantic matching)
  • Update README and default config with documentation

Closes #8

Test plan

  • cargo test — 147/147 pass
  • icm --no-embeddings stats works without model download
  • ICM_NO_EMBEDDINGS=1 icm recall "test" returns FTS results
  • Default behavior unchanged (embeddings enabled)

Three ways to disable embeddings (no model download, keyword search only):
- Config: [embeddings] enabled = false
- CLI flag: icm --no-embeddings <command>
- Env var: ICM_NO_EMBEDDINGS=1

Closes #8
@pszymkowiak pszymkowiak added enhancement New feature or request configuration labels Mar 16, 2026
@pszymkowiak
Copy link
Copy Markdown
Contributor Author

🧞 wshm · Automated triage by AI

📊 Automated PR Analysis

Type feature
🟢 Risk low

Summary

Adds three mechanisms (config flag, CLI flag, environment variable) to opt out of embedding model download at startup, falling back to FTS5 keyword search when disabled. Updates README and default config with documentation for the new options.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Linked issues: #8


🤖 Analyzed automatically by wshm · This is an automated analysis, not a human review.

@pszymkowiak pszymkowiak merged commit 5334d45 into main Mar 16, 2026
1 check passed
@pszymkowiak pszymkowiak deleted the fix/embedding-opt-out branch March 16, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No opt-out for the embedding model download

1 participant