fix: add opt-out for embedding model download#25
Merged
pszymkowiak merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
Three ways to disable embeddings (no model download, keyword search only): - Config: [embeddings] enabled = false - CLI flag: icm --no-embeddings <command> - Env var: ICM_NO_EMBEDDINGS=1 Closes #8
Contributor
Author
📊 Automated PR Analysis
SummaryAdds three mechanisms (config flag, CLI flag, environment variable) to opt out of embedding model download at startup, falling back to FTS5 keyword search when disabled. Updates README and default config with documentation for the new options. Review Checklist
Linked issues: #8 🤖 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[embeddings] enabled = falseicm --no-embeddings <command>ICM_NO_EMBEDDINGS=1Closes #8
Test plan
cargo test— 147/147 passicm --no-embeddings statsworks without model downloadICM_NO_EMBEDDINGS=1 icm recall "test"returns FTS results