Don't add a 'From:' header to the body if the email is a 'noreply' #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old logic included a 'From:' in-body header if the author of the commit was different to the person who was sending the email. However, commits generated through GitHub's interface often (always?) have an author email of `githubusername@users.noreply.github.com`, which is definitely _not_ preferable. PatchBomb emails by SubmitGit are always sent 'from' the user's *primary* email address in GitHub. See also: http://article.gmane.org/gmane.comp.version-control.git/286879 #28
rtyley
added a commit
that referenced
this pull request
Feb 26, 2016
…-addresses Don't add a 'From:' header to the body if the email is a 'noreply'
Collaborator
|
Thanks @rtyley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic included a 'From:' in-body header if the author of the commit was different to the person who was sending the email. However, commits generated through GitHub's interface often (always?) have an author email of
githubusername@users.noreply.github.com, which is definitely not preferable.PatchBomb emails by SubmitGit are always sent 'from' the user's primary email address in GitHub.
See also: #28
cc @PeterDaveHello