Merge pull request #5863 from MDoerner/CorrectlyResolveReferencesToDeclarationNamedLikeBuiltInTypes

Correctly resolve references to declarations named like built-in types

Author: retailcoder

Rubberduck.Parsing/Binding/DefaultBindingContext.cs

@@ -157,7 +157,7 @@ private IExpressionBinding Visit(Declaration module, Declaration parent, VBAPars
                 case VBAParser.MarkedFileNumberExprContext markedFileNumberExprContext:
                     return Visit(module, parent, markedFileNumberExprContext, withBlockVariable);
                 case VBAParser.BuiltInTypeExprContext builtInTypeExprContext:
-                    return Visit(builtInTypeExprContext);
+                    return Visit(module, parent, builtInTypeExprContext, statementContext);
                 //We do not handle the VBAParser.TypeofexprContext because that should only ever appear as a child of an IS relational operator expression and is specifically handled there.
                 default:
                     throw new NotSupportedException($"Unexpected expression type {expression.GetType()}");
@@ -209,8 +209,17 @@ private IExpressionBinding Visit(Declaration module, Declaration parent, VBAPars
             return Visit(module, parent, expression.expression(), withBlockVariable, StatementResolutionContext.Undefined);
         }
 
-        private IExpressionBinding Visit(VBAParser.BuiltInTypeExprContext expression)
+        private IExpressionBinding Visit(Declaration module, Declaration parent, VBAParser.BuiltInTypeExprContext expression, StatementResolutionContext statementContext)
         {
+            //It is legal to name variables like built-in types.
+            //So, we try and see whether it resolves.
+            var builtInTypeNamedNameBinding = new SimpleNameDefaultBinding(_declarationFinder, Declaration.GetProjectParent(parent), module, parent, expression, Identifier.GetName(expression.builtInType()), statementContext);
+            var resolutionResult = builtInTypeNamedNameBinding.Resolve();
+            if (resolutionResult.Classification != ExpressionClassification.ResolutionFailed)
+            {
+                return builtInTypeNamedNameBinding;
+            }
+
             // Not actually an expression, but treated as one to allow for a faster parser.
             return new BuiltInTypeDefaultBinding(expression);
         }

Rubberduck.Parsing/Symbols/Identifier.cs

@@ -190,6 +190,11 @@ public static string GetName(VBAParser.SimpleNameExprContext context)
             return GetName(context.identifier());
         }
 
+        public static string GetName(VBAParser.BuiltInTypeContext context)
+        {
+            return context.GetText();
+        }
+
         public static string GetName(VBAParser.IdentifierContext context, out Interval tokenInterval)
         {
             tokenInterval = Interval.Of(context.Start.TokenIndex, context.Stop.TokenIndex);

RubberduckTests/Inspections/ParameterNotUsedInspectionTests.cs

@@ -48,6 +48,19 @@ public void ParameterUsed_DoesNotReturnResult()
             Assert.AreEqual(0, InspectionResultsForStandardModule(inputCode).Count());
         }
 
+        [Test]
+        [Category("Inspections")]
+        //See issue #5336 at https://github.com/rubberduck-vba/Rubberduck/issues/5336
+        public void ParameterWithBuiltInTypeNameUsed_DoesNotReturnResult()
+        {
+            const string inputCode =
+                @"Public Function Foo(Object As Object) As Object
+Set Foo = Object
+End Function";
+
+            Assert.AreEqual(0, InspectionResultsForStandardModule(inputCode).Count());
+        }
+
         [Test]
         [Category("Inspections")]
         public void ParameterNotUsed_ReturnsResult_SomeParamsUsed()