fix broken tests

retailcoder · retailcoder · commit b9c9606ca0d3 · 2021-10-10T19:32:44.000-04:00
diff --git a/Rubberduck.CodeAnalysis/Inspections/Concrete/SuspiciousPredeclaredInstanceAccessInspection.cs b/Rubberduck.CodeAnalysis/Inspections/Concrete/SuspiciousPredeclaredInstanceAccessInspection.cs
@@ -86,13 +86,13 @@ protected override bool IsResultReference(IdentifierReference reference, Declara
                 reference.Declaration is ClassModuleDeclaration module && 
                 module.HasPredeclaredId &&
                 reference.ParentScoping.ParentDeclaration.Equals(module) &&
-                reference.Context.TryGetAncestor<VBAParser.LExpressionContext>(out var expression) &&
-                reference.IdentifierName != Tokens.Me && expression.GetText() == reference.IdentifierName;
+                reference.Context.TryGetAncestor<VBAParser.MemberAccessExprContext>(out var expression) &&
+                reference.IdentifierName != Tokens.Me && expression.lExpression()?.GetText() == reference.IdentifierName;
         }
 
         protected override string ResultDescription(IdentifierReference reference)
         {
-            reference.Context.TryGetAncestor<VBAParser.LExpressionContext>(out var expression);
+            reference.Context.TryGetAncestor<VBAParser.MemberAccessExprContext>(out var expression);
             return string.Format(InspectionResults.SuspiciousPredeclaredInstanceAccessInspection, reference.IdentifierName, expression.GetText());
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -86,13 +86,13 @@ protected override bool IsResultReference(IdentifierReference reference, Declara`
`86`	`86`	`reference.Declaration is ClassModuleDeclaration module &&`
`87`	`87`	`module.HasPredeclaredId &&`
`88`	`88`	`reference.ParentScoping.ParentDeclaration.Equals(module) &&`
`89`		`- reference.Context.TryGetAncestor<VBAParser.LExpressionContext>(out var expression) &&`
`90`		`- reference.IdentifierName != Tokens.Me && expression.GetText() == reference.IdentifierName;`
	`89`	`+ reference.Context.TryGetAncestor<VBAParser.MemberAccessExprContext>(out var expression) &&`
	`90`	`+ reference.IdentifierName != Tokens.Me && expression.lExpression()?.GetText() == reference.IdentifierName;`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`protected override string ResultDescription(IdentifierReference reference)`
`94`	`94`	`{`
`95`		`- reference.Context.TryGetAncestor<VBAParser.LExpressionContext>(out var expression);`
	`95`	`+ reference.Context.TryGetAncestor<VBAParser.MemberAccessExprContext>(out var expression);`
`96`	`96`	`return string.Format(InspectionResults.SuspiciousPredeclaredInstanceAccessInspection, reference.IdentifierName, expression.GetText());`
`97`	`97`	`}`
`98`	`98`	`}`