Skip to content

Conversation

@numbata
Copy link
Contributor

@numbata numbata commented Oct 24, 2025

This PR replaces the namespace_stackable access removed in Grape 3 with inheritable_setting usage so namespace aggregation still works, and raises the Grape dependency ceiling to < 4.0.

Fix #965

@dblock
Copy link
Member

dblock commented Oct 24, 2025

Looks good! Add to CHANGELOG, update README for versions, write some token_owner_resolver tests and we're good?

@numbata
Copy link
Contributor Author

numbata commented Oct 24, 2025

Absolutely! As usual.
But as no urgent rush here, I will do it tomorrow evening (by Stockholm time) and will look to the rest of the gems as well.

Probably CI Matrix needs to be updated also.

@dblock
Copy link
Member

dblock commented Oct 26, 2025

@numbata looks like legit CI failures

@numbata
Copy link
Contributor Author

numbata commented Oct 26, 2025

@dblock yes. Working on it. The issue is that helpers also should be taken for account during resolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression caused by removing namespace_stackable from public API

2 participants