Skip to content

Conversation

@alexanderadam
Copy link
Contributor

@alexanderadam alexanderadam commented Oct 21, 2025

As discussed here and as announced here.

PS: I'm looking for a new adventure in case anybody is looking to hire or work with a Ruby/Rails/Crystal dev
PPS: would you be so kind and add the hacktoberfest-accepted label to this issue in case you find that PR helpful? 🥺

@alexanderadam alexanderadam force-pushed the doc/remove_manual_toc_and_toc_danger_check branch from 4380506 to 077c25e Compare October 21, 2025 19:56
@dblock
Copy link
Member

dblock commented Oct 21, 2025

This might be more work :( Are we running https://github.com/ruby-grape/danger/blob/master/Dangerfile#L29?

@alexanderadam
Copy link
Contributor Author

alexanderadam commented Oct 23, 2025

Aaaah, I disabled it AND removed the TOC at the same time.
I think the Danger config is taken from the main branch (otherwise somebody could temper it).

Thus we need to do two PRs, I think: first one for Danger and the second for the TOC.

@alexanderadam alexanderadam force-pushed the doc/remove_manual_toc_and_toc_danger_check branch from 077c25e to 04346c9 Compare October 23, 2025 23:51
@alexanderadam alexanderadam changed the title Remove manual TOC and TOD Danger check Remove TOC Danger check Oct 23, 2025
@dblock
Copy link
Member

dblock commented Oct 24, 2025

I think the Danger config is taken from the main branch (otherwise somebody could temper it).

I am almost certain it's not, but this is a good change anyway because we check TOC twice.

@dblock dblock merged commit 57408ff into ruby-grape:master Oct 24, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants