Ability to handle incoming JSON in the body #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2011 11:54
This allows Grape to work with ActiveResource in JSON mode. If the body contains JSON, it's contents will be added to the params hash just like if they came over the GET query string or as regular params.
Didn't account for regular POST content being in the body on some requests, even if JSON is expected as the result. It now fails gracefully.
Contributor
|
Can you update this to merge cleanly with the latest master? If so, I'll accept it. |
added 2 commits
July 14, 2011 23:50
Conflicts: lib/grape/middleware/formatter.rb
Author
|
There you go. All tests pass, so I think it should be good. Thanks! |
mbleigh
pushed a commit
that referenced
this pull request
Jul 15, 2011
Ability to handle incoming JSON in the body
mbleigh
pushed a commit
that referenced
this pull request
Dec 5, 2011
Ability to handle incoming JSON in the body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Grape to work with ActiveResource in JSON mode. If the body contains JSON, it's contents will be added to the params hash just like if they came over the GET query string or as regular params.