This is a minor fix for the issue where nested attributes of hashes are still strings (c.f., sporkd's comment on https://github.com/intridea/grape/issues/27). #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s symbols as hash keys. That is, passing: /url?location[city]=Dallas&location[state]=TX will be available in the params hash as both * params[:location][:city] and params[:location][:state] * params['location']['city'] and params['location']['state']
Member
|
I want to merge this fix, but maybe a cleaner implementation could be to use hashie (https://github.com/intridea/hashie) that seems to abstract this problem away? There're was another pull that tries to do that that has it's own issues. Thoughts? |
Author
|
I'm not opposed to looking into this more. I haven't used Hashie but the extensions seem reasonable. Are you guys close to publishing Hashie 2.0? As far as I can tell it's unpublished so I can't add a runtime dependency in the gemspec. |
Member
|
@mbleigh can probably comment on Hashie - 1.1 doesn't do what you need I suppose |
dblock
pushed a commit
to dblock/grape
that referenced
this pull request
Dec 5, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating params such that the symbol version returned recursively uses symbols as hash keys.
That is, passing:
/url?location[city]=Dallas&location[state]=TX
will be available in the params hash as both