Skip to content

Commit 2101304

Browse files
committed
Spec more consistently, separate
1 parent 8b5ecb6 commit 2101304

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

spec/unit/ldap/search_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def search(args)
3535
end
3636

3737
context "when instrumentation_service is configured" do
38-
it "should emit a search.net_ldap event" do
38+
it "should publish a search.net_ldap event" do
3939
events = @service.subscribe "search.net_ldap"
4040

4141
@connection.search :filter => "test"

spec/unit/ldap_spec.rb

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -127,25 +127,35 @@
127127
:instrumentation_service => @service)
128128
end
129129

130-
it "should publish a socket write event, followed by a socket read event" do
130+
it "should publish a write.net_ldap_connection event" do
131131
ber = Net::BER::BerIdentifiedArray.new([0, "", ""])
132132
ber.ber_identifier = 7
133-
read_result = [2, ber]
134-
@tcp_socket.should_receive(:read_ber).and_return(read_result)
133+
@tcp_socket.should_receive(:read_ber).and_return([2, ber])
135134

136-
write_events = @service.subscribe "write.net_ldap_connection"
137-
read_events = @service.subscribe "read.net_ldap_connection"
135+
events = @service.subscribe "write.net_ldap_connection"
138136

139-
result = subject.modify(:dn => "1", :operations => [[:replace, "mail", "something@sothsdkf.com"]])
137+
result = subject.bind(method: :anon)
140138
result.should be_success
141139

142140
# a write event
143-
payload, result = write_events.pop
141+
payload, result = events.pop
144142
payload.should have_key(:result)
145143
payload.should have_key(:packet)
144+
end
145+
146+
it "should publish a read.net_ldap_connection event" do
147+
ber = Net::BER::BerIdentifiedArray.new([0, "", ""])
148+
ber.ber_identifier = 7
149+
read_result = [2, ber]
150+
@tcp_socket.should_receive(:read_ber).and_return(read_result)
151+
152+
events = @service.subscribe "read.net_ldap_connection"
153+
154+
result = subject.bind(method: :anon)
155+
result.should be_success
146156

147-
# then a read event
148-
payload, result = read_events.pop
157+
# a read event
158+
payload, result = events.pop
149159
payload.should have_key(:result)
150160
result.should == read_result
151161
end

0 commit comments

Comments
 (0)