Skip to content

Commit 97fbae9

Browse files
Austin Zieglerkschiess
authored andcommitted
Adding a Hacking document.
1 parent 1589556 commit 97fbae9

File tree

3 files changed

+31
-7
lines changed

3 files changed

+31
-7
lines changed

Hacking.rdoc

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
= Hacking Net::LDAP
2+
3+
We welcome your contributions to Net::LDAP. To increase the chances of your
4+
patches being accepted, we recommend that you follow the guidelines below:
5+
6+
1. Your code should be formatted like the rest of Net::LDAP. We use a text
7+
wrap of 76 - 78 characters, especially for documentation contents.
8+
Operators should have spaces around them, method definitions should have
9+
parentheses around arguments. Keep the indentation as flat as possible.
10+
2. Your changes should be well-documented and described.
11+
3. You must provide rspec tests for any new or changed features. Rspec has
12+
been chosen as the way forward for tests.
13+
4. You should provide LDIF data for importing into LDAP servers so that the
14+
changes can be tested <em>in situ</em> with more than one real LDAP
15+
server.
16+
5. You should have tested your changes against a real LDAP server.

Manifest.txt

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
COPYING
2+
Hacking.rdoc
23
History.txt
34
LICENSE
45
Manifest.txt
@@ -7,14 +8,14 @@ Rakefile
78
lib/net-ldap.rb
89
lib/net/ber.rb
910
lib/net/ber/ber_parser.rb
11+
lib/net/ber/core_ext.rb
12+
lib/net/ber/core_ext/array.rb
13+
lib/net/ber/core_ext/bignum.rb
14+
lib/net/ber/core_ext/false_class.rb
15+
lib/net/ber/core_ext/fixnum.rb
16+
lib/net/ber/core_ext/string.rb
17+
lib/net/ber/core_ext/true_class.rb
1018
lib/net/ldap.rb
11-
lib/net/ldap/core_ext/all.rb
12-
lib/net/ldap/core_ext/array.rb
13-
lib/net/ldap/core_ext/bignum.rb
14-
lib/net/ldap/core_ext/false_class.rb
15-
lib/net/ldap/core_ext/fixnum.rb
16-
lib/net/ldap/core_ext/string.rb
17-
lib/net/ldap/core_ext/true_class.rb
1819
lib/net/ldap/dataset.rb
1920
lib/net/ldap/entry.rb
2021
lib/net/ldap/filter.rb
@@ -26,6 +27,10 @@ spec/integration/ssl_ber_spec.rb
2627
spec/spec.opts
2728
spec/spec_helper.rb
2829
spec/unit/ber/ber_spec.rb
30+
spec/unit/ber/core_ext/string_spec.rb
31+
spec/unit/ldap/entry_spec.rb
32+
spec/unit/ldap/filter_spec.rb
33+
spec/unit/ldap_spec.rb
2934
test/common.rb
3035
test/test_ber.rb
3136
test/test_entry.rb

Rakefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
require "rubygems"
2+
require 'hanna/rdoctask'
23
require 'hoe'
34

45
$LOAD_PATH.unshift('lib')
@@ -33,6 +34,8 @@ Hoe.spec PKG_NAME do
3334
self.changes = paragraphs_of(self.history_file, 0..1).join("\n\n")
3435
self.description = paragraphs_of(self.readme_file, 2..2).join("\n\n")
3536

37+
extra_rdoc_files << "Hacking.rdoc"
38+
3639
extra_dev_deps << [ "archive-tar-minitar", "~>0.5.1" ]
3740
extra_dev_deps << [ "hanna", "~>0.1.2" ]
3841
extra_dev_deps << [ "hoe-git", "~>1" ]

0 commit comments

Comments
 (0)