Update README.md with gemspec #355
Conversation
jethrodaniel
left a comment
jethrodaniel
left a comment
There was a problem hiding this comment.
If you're adding development info, you might also want to add something about using bundler as well
git clone https://github.com/ruby-ldap/ruby-net-ldap
cd ruby-net-ldap
gem install bundler # if you don't have it
bundle # or bundle install
bundle exec rake rubotest
In fact, bundler usage is mentioned in CONTRIBUTING.md.
Additionally, gem build ..., is usually followed by gem install ... - or you can use bundler's rake tasks to do that for you (bundle exec rake build, bundle exec rake install).
Also, the changes to lib/net/ldap.rb would be best as another PR.
(cherry picked from commit b54d7b1)
|
Thank you for the feedback @jethrodaniel. Have updated the README as per your suggestions. Will raise separate PRs for the rest of the changes |
|
👍 thanks |
| :hosts => @hosts, | ||
| :encryption => @encryption, | ||
| :instrumentation_service => @instrumentation_service, | ||
| :socket_class => @socket_class, |
There was a problem hiding this comment.
Changes to this file should be in a separate PR.
| :hosts => @hosts, | ||
| :encryption => @encryption, | ||
| :instrumentation_service => @instrumentation_service, | ||
| :socket_class => @socket_class, |
|
Closing as stale. Please open a new PR if there' something else you'd like to add. Thank you! |
4 participants
Updates README.md