Skip to content

Fix cross-platform negative value conversion for unsigned integer types #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix cross-platform negative value conversion for unsigned integer types #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2167636
Update GitHub Actions workflow
kojix2 May 24, 2025
7ee732f
Fix cross-platform negative value conversion for unsigned integer types
kojix2 May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@ on: [push, pull_request]
jobs:
MRI:
name: ${{ matrix.os }} ruby-${{ matrix.ruby }}
runs-on: ${{ matrix.os }}
runs-on: ${{ matrix.os }}-latest
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-11, windows-2022]
ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3', head]
include:
- { os: windows-2022 , ruby: mswin }
os: ['ubuntu', 'macos', 'windows']
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3', '3.4', head]
steps:
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby }}
Expand Down
5 changes: 3 additions & 2 deletions ext/numo/narray/numo/types/xint_macro.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@

#define m_extract(x) m_data_to_num(*(dtype*)(x))

#define m_from_double(x) (x)
#define m_from_real(x) (x)
/* Handle negative values consistently across platforms for unsigned integer types */
#define m_from_double(x) ((x) < 0 ? (dtype)((long long)(x)) : (dtype)(x))
#define m_from_real(x) ((x) < 0 ? (dtype)((long long)(x)) : (dtype)(x))
#define m_from_sint(x) (x)
#define m_from_int32(x) (x)
#define m_from_int64(x) (x)
Expand Down
Loading