Improve performance of x**y when y is a huge value #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When y.exponent is several thousand or more,
x**y
was slow because exponentiation by squaring requires several thousands of multiplications.Use exp and log in such case.
Appropriate threshold of
y.exponent
depends on exp, log, and multiplication performance.This condition is tuned with
prec <= 1000000
and #407 #433 applied.Theoretically, the condition should be
y.exponent > coef * log(prec)**a
where a is between1..3
, I guess.