Skip to content

Just the parent path of the destination symlink should exist #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025
Merged

Just the parent path of the destination symlink should exist #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/fileutils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ def ln_sr(src, dest, target_directory: true, force: nil, noop: nil, verbose: nil
real_ddirs = fu_split_path(File.realpath(parent))
else
destdirs ||= fu_split_path(dest)
real_ddirs ||= fu_split_path(File.realpath(dest))
real_ddirs ||= fu_split_path(File.realdirpath(dest))
end
srcdirs = fu_split_path(s)
i = fu_common_components(srcdirs, destdirs)
Expand Down
6 changes: 5 additions & 1 deletion test/fileutils/test_fileutils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,11 @@ def test_ln_sr_not_target_directory
assert_raise(Errno::EEXIST, Errno::EACCES) {
ln_sr fname, 'tmp', target_directory: false
}
assert_file.not_exist? File.join('tmp/', File.basename(fname))
dest = File.join('tmp/', File.basename(fname))
assert_file.not_exist? dest
ln_sr fname, dest, target_directory: false
assert_file.symlink?(dest)
assert_equal("../#{fname}", File.readlink(dest))
end
end if have_symlink?

Expand Down
Loading