Skip to content

Commit 0a4fb79

Browse files
committed
fbuffer.h: Use size_t over unsigned long
unsigned long is only 32b on some platforms.
1 parent a29fcdc commit 0a4fb79

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

ext/json/ext/fbuffer/fbuffer.h

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ enum fbuffer_type {
1111

1212
typedef struct FBufferStruct {
1313
enum fbuffer_type type;
14-
unsigned long initial_length;
15-
unsigned long len;
16-
unsigned long capa;
14+
size_t initial_length;
15+
size_t len;
16+
size_t capa;
1717
#if JSON_DEBUG
18-
unsigned long requested;
18+
size_t requested;
1919
#endif
2020
char *ptr;
2121
VALUE io;
@@ -32,12 +32,12 @@ typedef struct FBufferStruct {
3232

3333
static void fbuffer_free(FBuffer *fb);
3434
static void fbuffer_clear(FBuffer *fb);
35-
static void fbuffer_append(FBuffer *fb, const char *newstr, unsigned long len);
35+
static void fbuffer_append(FBuffer *fb, const char *newstr, size_t len);
3636
static void fbuffer_append_long(FBuffer *fb, long number);
3737
static inline void fbuffer_append_char(FBuffer *fb, char newchr);
3838
static VALUE fbuffer_finalize(FBuffer *fb);
3939

40-
static void fbuffer_stack_init(FBuffer *fb, unsigned long initial_length, char *stack_buffer, long stack_buffer_size)
40+
static void fbuffer_stack_init(FBuffer *fb, size_t initial_length, char *stack_buffer, size_t stack_buffer_size)
4141
{
4242
fb->initial_length = (initial_length > 0) ? initial_length : FBUFFER_INITIAL_LENGTH_DEFAULT;
4343
if (stack_buffer) {
@@ -50,7 +50,7 @@ static void fbuffer_stack_init(FBuffer *fb, unsigned long initial_length, char *
5050
#endif
5151
}
5252

53-
static inline void fbuffer_consumed(FBuffer *fb, unsigned long consumed)
53+
static inline void fbuffer_consumed(FBuffer *fb, size_t consumed)
5454
{
5555
#if JSON_DEBUG
5656
if (consumed > fb->requested) {
@@ -79,7 +79,7 @@ static void fbuffer_flush(FBuffer *fb)
7979
fbuffer_clear(fb);
8080
}
8181

82-
static void fbuffer_realloc(FBuffer *fb, unsigned long required)
82+
static void fbuffer_realloc(FBuffer *fb, size_t required)
8383
{
8484
if (required > fb->capa) {
8585
if (fb->type == FBUFFER_STACK_ALLOCATED) {
@@ -94,7 +94,7 @@ static void fbuffer_realloc(FBuffer *fb, unsigned long required)
9494
}
9595
}
9696

97-
static void fbuffer_do_inc_capa(FBuffer *fb, unsigned long requested)
97+
static void fbuffer_do_inc_capa(FBuffer *fb, size_t requested)
9898
{
9999
if (RB_UNLIKELY(fb->io)) {
100100
if (fb->capa < FBUFFER_IO_BUFFER_SIZE) {
@@ -108,7 +108,7 @@ static void fbuffer_do_inc_capa(FBuffer *fb, unsigned long requested)
108108
}
109109
}
110110

111-
unsigned long required;
111+
size_t required;
112112

113113
if (RB_UNLIKELY(!fb->ptr)) {
114114
fb->ptr = ALLOC_N(char, fb->initial_length);
@@ -120,7 +120,7 @@ static void fbuffer_do_inc_capa(FBuffer *fb, unsigned long requested)
120120
fbuffer_realloc(fb, required);
121121
}
122122

123-
static inline void fbuffer_inc_capa(FBuffer *fb, unsigned long requested)
123+
static inline void fbuffer_inc_capa(FBuffer *fb, size_t requested)
124124
{
125125
#if JSON_DEBUG
126126
fb->requested = requested;
@@ -131,13 +131,13 @@ static inline void fbuffer_inc_capa(FBuffer *fb, unsigned long requested)
131131
}
132132
}
133133

134-
static inline void fbuffer_append_reserved(FBuffer *fb, const char *newstr, unsigned long len)
134+
static inline void fbuffer_append_reserved(FBuffer *fb, const char *newstr, size_t len)
135135
{
136136
MEMCPY(fb->ptr + fb->len, newstr, char, len);
137137
fbuffer_consumed(fb, len);
138138
}
139139

140-
static inline void fbuffer_append(FBuffer *fb, const char *newstr, unsigned long len)
140+
static inline void fbuffer_append(FBuffer *fb, const char *newstr, size_t len)
141141
{
142142
if (len > 0) {
143143
fbuffer_inc_capa(fb, len);
@@ -162,7 +162,7 @@ static inline void fbuffer_append_reserved_char(FBuffer *fb, char chr)
162162
static void fbuffer_append_str(FBuffer *fb, VALUE str)
163163
{
164164
const char *ptr;
165-
unsigned long len;
165+
size_t len;
166166
RSTRING_GETMEM(str, ptr, len);
167167

168168
fbuffer_append(fb, ptr, len);
@@ -171,7 +171,7 @@ static void fbuffer_append_str(FBuffer *fb, VALUE str)
171171
static void fbuffer_append_str_repeat(FBuffer *fb, VALUE str, size_t repeat)
172172
{
173173
const char *ptr;
174-
unsigned long len;
174+
size_t len;
175175
RSTRING_GETMEM(str, ptr, len);
176176

177177
fbuffer_inc_capa(fb, repeat * len);

0 commit comments

Comments
 (0)