Avoid method redefinition warnings in test_broken_bignum

Author: byroot

lib/json/truffle_ruby/generator.rb

@@ -413,7 +413,7 @@ def generate(obj, anIO = nil)
               buf << obj.to_json(self)
             end
           when Integer
-            buf << obj.to_s
+            buf << String(obj)
           when Symbol
             if @strict
               fast_serialize_string(obj.name, buf)
@@ -652,7 +652,9 @@ def json_transform(state)
 
         module Integer
           # Returns a JSON string representation for this Integer number.
-          def to_json(*) to_s end
+          def to_json(*)
+            String(self)
+          end
         end
 
         module Float

test/json/json_generator_test.rb

@@ -493,20 +493,27 @@ def foo.to_h
     assert_equal '2', state.indent
   end
 
-  if defined?(JSON::Ext::Generator) and RUBY_PLATFORM != "java"
-    def test_broken_bignum # [ruby-core:38867]
-      bignum = 1 << 64
-      original_to_s = bignum.class.instance_method(:to_s)
-      bignum.class.class_eval do
-        def to_s
-        end
+  def test_broken_bignum # [Bug #5173]
+    bignum = 1 << 64
+    bignum_to_s = bignum.to_s
+
+    original_to_s = bignum.class.instance_method(:to_s)
+    bignum.class.class_eval do
+      def to_s
+        nil
       end
+      alias_method :to_s, :to_s
+    end
+    case RUBY_PLATFORM
+    when "java"
+      assert_equal bignum_to_s, JSON.generate(bignum)
+    else
       assert_raise(TypeError) do
-        JSON::Ext::Generator::State.new.generate(bignum)
+        JSON.generate(bignum)
       end
-    ensure
-      bignum.class.define_method(:to_s, original_to_s) if original_to_s
     end
+  ensure
+    bignum.class.define_method(:to_s, original_to_s) if original_to_s
   end
 
   def test_hash_likeness_set_symbol