Skip to content

Backport #349: 🐛 Fix SequenceSet.try_convert #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Backport #349: 🐛 Fix SequenceSet.try_convert #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/imap/sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def [](first, *rest)
# raised.
def try_convert(obj)
return obj if obj.is_a?(SequenceSet)
return nil unless respond_to?(:to_sequence_set)
return nil unless obj.respond_to?(:to_sequence_set)
obj = obj.to_sequence_set
return obj if obj.is_a?(SequenceSet)
raise DataFormatError, "invalid object returned from to_sequence_set"
Expand Down
16 changes: 16 additions & 0 deletions test/net/imap/test_sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,22 @@ def compare_to_reference_set(nums, set, seqset)
assert_raise DataFormatError do SequenceSet[""] end
end

test ".try_convert" do
assert_nil SequenceSet.try_convert(nil)
assert_nil SequenceSet.try_convert(123)
assert_nil SequenceSet.try_convert(12..34)
assert_nil SequenceSet.try_convert("12:34")
assert_nil SequenceSet.try_convert(Object.new)

obj = Object.new
def obj.to_sequence_set; SequenceSet[192, 168, 1, 255] end
assert_equal SequenceSet[192, 168, 1, 255], SequenceSet.try_convert(obj)

obj = Object.new
def obj.to_sequence_set; 192_168.001_255 end
assert_raise DataFormatError do SequenceSet.try_convert(obj) end
end

test "#[non-negative index]" do
assert_nil SequenceSet.empty[0]
assert_equal 1, SequenceSet[1..][0]
Expand Down