Skip to content

Add Net::Protocol::TCP_SOCKET_NEW_HAS_OPEN_TIMEOUT #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eregon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Net::Protocol::TCP_SOCKET_NEW_HAS_OPEN_TIMEOUT #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
738c06f
Add Net::Protocol::TCP_SOCKET_NEW_HAS_OPEN_TIMEOUT
eregon Dec 8, 2025
c847e49
Use fail-fast: false in CI
eregon Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
needs: ruby-verions
name: build (${{ matrix.ruby }} / ${{ matrix.os }})
strategy:
fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-verions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest, windows-latest ]
Expand Down
10 changes: 10 additions & 0 deletions lib/net/protocol.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,16 @@ def ssl_socket_connect(s, timeout)
s.connect
end
end

tcp_socket_parameters = TCPSocket.instance_method(:initialize).parameters
TCP_SOCKET_NEW_HAS_OPEN_TIMEOUT = if tcp_socket_parameters != [[:rest]]
tcp_socket_parameters.include?([:key, :open_timeout])
else
# Use Socket.tcp to find out since there is no parameters information for TCPSocket#initialize
# See discussion in https://github.com/ruby/net-http/pull/224
Socket.method(:tcp).parameters.include?([:key, :open_timeout])
end
private_constant :TCP_SOCKET_NEW_HAS_OPEN_TIMEOUT
end


Expand Down