extconf.h should not be checked in #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extconf.rb [generates the header file](https://github.com/ruby/openssl/blob/dbb3fdb3df0aca3ff8a617dd33ff9ffd1a7f53a2/ext/openssl/extconf.rb#L157), so we should not check it in.
zzak
pushed a commit
that referenced
this pull request
Jul 22, 2015
extconf.h should not be checked in
peterzhu2118
added a commit
that referenced
this pull request
Nov 15, 2025
OpenSSL::Provider does not automatically unload at shutdown, causing it
to be reported as a memory leak by memory leak checkers when using
RUBY_FREE_AT_EXIT. For example, LSAN reports many memory leaks that looks
like this:
#15 0x78dd17e2dfb4 (/lib/x86_64-linux-gnu/libcrypto.so.3+0x22dfb4)
#16 0x78dd17e2b195 in OSSL_PROVIDER_try_load (/lib/x86_64-linux-gnu/libcrypto.so.3+0x22b195)
#17 0x78dd35ba8751 in ossl_provider_s_load ext/openssl/ossl_provider.c:60:16
This commit adds a hook at shutdown to unload all the OpenSSL providers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extconf.rb generates the header file, so we should not check it in.