Java generated code should generate an enum (or static final ints) for versions once versioning is settled

[enebo]

I am manually writing 5 for 3.3 support in the request for serialized source but this ultimately should be passing a value that is referenced from code generated by prism.

There seems to still be some questions on how versioning will be handled and I will not need anything other than 3.3 support for at least a year so this is not all that important. Just reminding us that we should add something eventually.

[eregon]

Indeed.
Currently the versions constants are only part of the header at

prism/include/prism/options.h

Lines 32 to 38 in 5f46d36

	typedef enum {
	/** The current version of prism. */
	PM_OPTIONS_VERSION_LATEST = 0,
	/** The vendored version of prism in CRuby 3.3.0. */
	PM_OPTIONS_VERSION_CRUBY_3_3_0 = 1
	} pm_options_version_t;

and in lib/prism/ffi.rb.

I am manually writing 5

5 doesn't seem to correspond to any of these constants, but maybe I'm missing something?

The version for serialization seems not yet documented in https://github.com/ruby/prism/blob/main/docs/serialization.md but it was added in https://github.com/ruby/prism/pull/2118/files#diff-3eb9e99cab36d75a322185ffbcfb68f5337241fd0ad897c79359f87d5f2d510d, I'll make a PR for that.

It seems JRuby wants the same as TruffleRuby for now, nice (#2163).

[enebo]

@eregon haha. I was not looking to closely I saw the 5 from the strncmp. A case of moving too quickly to remove hs_err core dumps.

[kddnewton]

I think this is done now, unless I'm misreading.

[eregon]

Yes, added in #2304