Skip to content

Conversation

@ahorek
Copy link

@ahorek ahorek commented Mar 18, 2020

@hsbt
Copy link
Member

hsbt commented Mar 19, 2020

@headius Can you review this?

Copy link
Contributor

@headius headius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is safe and works on all JRuby versions. From JRuby 9.3 forward this require is needed to expose some JRuby-specific utility functions.

@benoittgt
Copy link

We have now another error. Is this related?

An error occurred while loading spec_helper. - Did you mean?
                    rspec ./spec/spec_helper.rb

Failure/Error:
  ControllerAssertionDelegator = RSpec::Rails::AssertionDelegator.new(
    ActionDispatch::Assertions::RoutingAssertions
  )

LoadError:
  no such file to load -- racc/info
# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:291:in `block in require'
# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:257:in `load_dependency'
# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:291:in `require'
# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:291:in `block in require'
# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:257:in `load_dependency'
# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:291:in `require'
# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/nokogiri-1.9.1-java/lib/nokogiri/css/parser.rb:7:in `<main>'

https://travis-ci.org/github/rspec/rspec-rails/jobs/665433957?utm_medium=notification&utm_source=github_status

@headius
Copy link
Contributor

headius commented Mar 24, 2020

Is this related?

JRuby previously only shipped the extension and parser.rb because the rest of the source was licensed under something GPL-ish. That license has changed and parser.rb expects the rest of the gem to be present. I've fixed this by committing the rest of the racc library files for #6125.

We would prefer to source those files from the gem, but that will require @hsbt or someone else responsible for the racc gem to do a release.

@hsbt
Copy link
Member

hsbt commented Mar 24, 2020

@headius I'm going to release the current master branch as racc-1.5.0 after cleaning-up the some of obsoleted files.

@hsbt
Copy link
Member

hsbt commented Mar 25, 2020

@headius
Copy link
Contributor

headius commented Apr 13, 2020

@hsbt Missed this until now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

undefined method runtime' for JRuby:Module on Travis CI when running rubocop for rspec-rails`

5 participants