Skip to content

Conversation

@k0kubun
Copy link
Member

@k0kubun k0kubun commented Jan 6, 2024

The current truffleruby-head doesn't seem to work well with cool.io. This CI job is supposed to test ./run_benchmarks.rb, not TruffleRuby. Let's avoid failing the CI until TruffleRuby is fixed.

@eregon
Copy link
Member

eregon commented Jan 8, 2024

Could we skip the problematic benchmark instead?

I added it in #251 so it would at least notice regressions for existing benchmarks.
If we do step-level continue-on-error, nobody will notice any regression.

@eregon
Copy link
Member

eregon commented Jan 8, 2024

The error seems https://github.com/Shopify/yjit-bench/actions/runs/7064460115/job/19232535306 on fluentd.
I will take a look. Weird it regressed.

@eregon
Copy link
Member

eregon commented Jan 8, 2024

BTW I had forgotten to add it https://github.com/eregon/truffleruby-gem-tracker, I added it now, so I should notice within a week if it starts failing (after it's fixed).

@eregon
Copy link
Member

eregon commented Jan 8, 2024

Fix in truffleruby/truffleruby#3372

@k0kubun
Copy link
Member Author

k0kubun commented Jan 8, 2024

Thanks for fixing it. As of this moment, the truffleruby-head on GitHub Actions is still failing, so I added a way to skip only fluentd for truffleruby-head as you suggested 23b658e.

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k0kubun k0kubun merged commit 2ae2b67 into ruby:main Jan 8, 2024
@k0kubun k0kubun deleted the skip-truffleruby branch January 8, 2024 22:03
@eregon
Copy link
Member

eregon commented Jan 9, 2024

Self notes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants