-
Notifications
You must be signed in to change notification settings - Fork 30
Avoid failing CI on TruffleRuby #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could we skip the problematic benchmark instead? I added it in #251 so it would at least notice regressions for existing benchmarks. |
|
The error seems https://github.com/Shopify/yjit-bench/actions/runs/7064460115/job/19232535306 on |
|
BTW I had forgotten to add it https://github.com/eregon/truffleruby-gem-tracker, I added it now, so I should notice within a week if it starts failing (after it's fixed). |
|
Fix in truffleruby/truffleruby#3372 |
|
Thanks for fixing it. As of this moment, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Self notes:
|
The current
truffleruby-headdoesn't seem to work well with cool.io. This CI job is supposed to test./run_benchmarks.rb, not TruffleRuby. Let's avoid failing the CI until TruffleRuby is fixed.