Skip to content

Conversation

@k0kubun
Copy link
Member

@k0kubun k0kubun commented Nov 14, 2024

I have a patch that consistently improves a benchmark by 0.5%. That, however, is rendered as 1.00 since "%.2f" % 1.005 returns that. Since we sometimes work on small optimizations, it might be useful to show one more number.

Before

-----  -----------  ----------  ----------  ----------  -------------  ------------
bench  before (ms)  stddev (%)  after (ms)  stddev (%)  after 1st itr  before/after
mail   69.8         0.4         69.4        0.2         1.00           1.00 
-----  -----------  ----------  ----------  ----------  -------------  ------------

After

-----  -----------  ----------  ----------  ----------  -------------  ------------
bench  before (ms)  stddev (%)  after (ms)  stddev (%)  after 1st itr  before/after
mail   69.8         0.4         69.4        0.2         1.004          1.005
-----  -----------  ----------  ----------  ----------  -------------  ------------

@maximecb maximecb merged commit 6433b02 into ruby:main Nov 14, 2024
4 checks passed
@k0kubun k0kubun deleted the three-precision branch November 14, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants