Skip to content

Ignore generated file from RuboCop#123

Merged
soutaro merged 1 commit intoruby:masterfrom
pocke:exlucde-parser.rb-from-rubocop
Dec 21, 2019
Merged

Ignore generated file from RuboCop#123
soutaro merged 1 commit intoruby:masterfrom
pocke:exlucde-parser.rb-from-rubocop

Conversation

@pocke
Copy link
Member

@pocke pocke commented Dec 21, 2019

rubocop-rubycw has been introduced by #113, but it records offenses in my local.

$ bundle exec rake rubocop
Inspecting 44 files
...........................C................

Offenses:

lib/ruby/signature/parser.rb:2988:1: C: Rubycw/Rubycw: mismatched indentations at 'end' with 'module' at 9
    end   # module Signature
^
lib/ruby/signature/parser.rb:2989:1: C: Rubycw/Rubycw: mismatched indentations at 'end' with 'module' at 8
  end   # module Ruby
^

44 files inspected, 2 offenses detected

So this pull request suppresses the warnings by adding the generated file to the exclude list.


By the way, I'm not sure why the cop does not add offense on Travis CI. The builds are green on the master and other pull requests.

@soutaro soutaro merged commit 5b4bee6 into ruby:master Dec 21, 2019
@pocke pocke deleted the exlucde-parser.rb-from-rubocop branch December 21, 2019 16:04
@hanachin
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants