Skip to content

Add rbs parse subcommand#207

Merged
soutaro merged 2 commits intoruby:masterfrom
pocke:check-subcommand
Feb 24, 2020
Merged

Add rbs parse subcommand#207
soutaro merged 2 commits intoruby:masterfrom
pocke:check-subcommand

Conversation

@pocke
Copy link
Copy Markdown
Member

@pocke pocke commented Feb 20, 2020

This pull request will adds rbs check sub-command to check syntax error from .rbs files.

For example:

$ cat test.rbs
class C
  def foo: () ->
end

$ rbs check test.rbs
test.rbs:3:0: parse error on value: (kEND)

@soutaro
Copy link
Copy Markdown
Member

soutaro commented Feb 20, 2020

The feature looks good. I'm wondering if there is a better name than rbs check.

  • rbs parse
  • rbs -C validate
  • rbs syntax
  • ... any other?

I don't think one of the above is better...

@pocke
Copy link
Copy Markdown
Member Author

pocke commented Feb 20, 2020

Hmm, I understand your concern.
I have the following ideas, but I'm not sure they are better.

  • rbs syntax-check
  • rbs syntax_check
  • rbs validate

@soutaro
Copy link
Copy Markdown
Member

soutaro commented Feb 23, 2020

I'd like to propose rbs parse. It parses the input and prints syntax errors if detected.

@pocke
Copy link
Copy Markdown
Member Author

pocke commented Feb 23, 2020

Sure! I renamed the command to rbs parse. 38e3692

@pocke pocke changed the title Add rbs check subcommand Add rbs parse subcommand Feb 23, 2020
@soutaro soutaro merged commit 0596895 into ruby:master Feb 24, 2020
@soutaro
Copy link
Copy Markdown
Member

soutaro commented Feb 24, 2020

@pocke Thanks! 🎉

@pocke pocke deleted the check-subcommand branch February 24, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants