Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Modify TestSSL#test_read_and_write to handle partial sysreads. #204

Closed
wants to merge 2 commits into
from

Conversation

2 participants

headius commented Oct 24, 2012

SSLSocket#sysread can return fewer bytes than you request. This test does client reads and writes and server reads and writes concurrently, which means on a parallel-threaded implementation like JRuby there's a chance the client side will see partial data come from sysread.

My change here ensures that the sysread has read everything written before doing comparisons, allowing for partial sysread results.

headius commented Oct 25, 2012

Added an additional tweak for the readpartial test in test_pair, which also assumes reads will always immediately return the complete result.

Member

zzak commented Nov 19, 2012

Closing this, please refer to Bug #7398 in redmine

@zzak zzak closed this Nov 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment