New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the method owner in backtraces #9605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mame
force-pushed
the
method-owner-in-backtrace
branch
4 times, most recently
from
January 19, 2024 08:45
738f7fe
to
578bee3
Compare
Try on Playground: https://ruby.github.io/play-ruby?run=7913922561 |
mame
force-pushed
the
method-owner-in-backtrace
branch
3 times, most recently
from
February 15, 2024 09:14
00149f7
to
5db8acb
Compare
Instead of having iseq and cfunc separately, this change lets Thread::Backtrace::Location have them together as rb_callable_method_entry_t. This is a refactoring, but also a preparation for implementing [Feature #19117].
``` test.rb:1:in 'Object#toplevel_meth': unhandled exception from test.rb:4:in 'Foo.class_meth' from test.rb:6:in 'Foo#instance_meth' from test.rb:11:in 'singleton_meth' from test.rb:13:in '<main>' ``` [Feature #19117]
mame
force-pushed
the
method-owner-in-backtrace
branch
from
February 15, 2024 09:43
5db8acb
to
78e97a5
Compare
st0012
added a commit
to ruby/irb
that referenced
this pull request
Feb 15, 2024
ruby/ruby#9605 changes the start quote from "`" to "'", which causes the tests to fail. This commit relaxes the assertions to allow for both types of quotes.
st0012
added a commit
to ruby/irb
that referenced
this pull request
Feb 15, 2024
ruby/ruby#9605 changes both quotes and format for exception messages. So we need to update the assertions in the tests.
tompng
pushed a commit
to ruby/irb
that referenced
this pull request
Feb 15, 2024
ruby/ruby#9605 changes both quotes and format for exception messages. So we need to update the assertions in the tests.
st0012
added a commit
to ruby/irb
that referenced
this pull request
Feb 16, 2024
With ruby/ruby#9605, backtrace in Ruby head now has a new format. This commit updates the check for binding.irb to work with Ruby head.
st0012
added a commit
to ruby/irb
that referenced
this pull request
Feb 16, 2024
* Update binding.irb check for Ruby head With ruby/ruby#9605, backtrace in Ruby head now has a new format. This commit updates the check for binding.irb to work with Ruby head. * Do not include a backtick in error messages and backtraces [Feature #16495] --------- Co-authored-by: Yusuke Endoh <mame@ruby-lang.org>
matzbot
pushed a commit
that referenced
this pull request
Feb 19, 2024
(ruby/irb#874) #9605 changes both quotes and format for exception messages. So we need to update the assertions in the tests. ruby/irb@9359d4b51d
matzbot
pushed a commit
that referenced
this pull request
Feb 19, 2024
(ruby/irb#876) * Update binding.irb check for Ruby head With #9605, backtrace in Ruby head now has a new format. This commit updates the check for binding.irb to work with Ruby head. * Do not include a backtick in error messages and backtraces [Feature #16495] --------- ruby/irb@ebffd3d976 Co-authored-by: Yusuke Endoh <mame@ruby-lang.org>
kachick
added a commit
to kachick/ruby-ulid
that referenced
this pull request
Feb 19, 2024
#494 (comment) ruby-head changed the message format ruby/ruby#9605 ruby/ruby@9ec9910
kachick
added a commit
to kachick/ruby-ulid
that referenced
this pull request
Feb 19, 2024
Follow new error message format ruby/ruby#9605 ruby/ruby@9ec9910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/19117