Skip to content

Commit acc0659

Browse files
hsbtclaude
andcommitted
Reorder plugin event definitions chronologically
Arrange events.rb by actual firing order so the file reads as a timeline of bundler's lifecycle: Gemfile eval, install-all bracket (with per-gem fetch, git fetch, and install nested inside), then require-all bracket (with per-gem require nested inside). Also clarify the git fetch hook docstrings: the hook fires around both remote fetch and checkout, not only fetch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent a08ea29 commit acc0659

1 file changed

Lines changed: 36 additions & 36 deletions

File tree

bundler/lib/bundler/plugin/events.rb

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,22 @@ def self.defined_event?(event)
3131
end
3232

3333
# @!parse
34-
# A hook called before each individual gem is installed
35-
# Includes a Bundler::ParallelInstaller::SpecInstallation.
36-
# No state, error, post_install_message will be present as nothing has installed yet
37-
# GEM_BEFORE_INSTALL = "before-install"
38-
define :GEM_BEFORE_INSTALL, "before-install"
34+
# A hook called before the Gemfile is evaluated
35+
# Includes the Gemfile path and the Lockfile path
36+
# GEM_BEFORE_EVAL = "before-eval"
37+
define :GEM_BEFORE_EVAL, "before-eval"
3938

4039
# @!parse
41-
# A hook called after each individual gem is installed
42-
# Includes a Bundler::ParallelInstaller::SpecInstallation.
43-
# - If state is failed, an error will be present.
44-
# - If state is success, a post_install_message may be present.
45-
# GEM_AFTER_INSTALL = "after-install"
46-
define :GEM_AFTER_INSTALL, "after-install"
40+
# A hook called after the Gemfile is evaluated
41+
# Includes a Bundler::Definition
42+
# GEM_AFTER_EVAL = "after-eval"
43+
define :GEM_AFTER_EVAL, "after-eval"
44+
45+
# @!parse
46+
# A hook called before any gems install
47+
# Includes an Array of Bundler::Dependency objects
48+
# GEM_BEFORE_INSTALL_ALL = "before-install-all"
49+
define :GEM_BEFORE_INSTALL_ALL, "before-install-all"
4750

4851
# @!parse
4952
# A hook called before each individual gem is downloaded from a remote source.
@@ -58,29 +61,44 @@ def self.defined_event?(event)
5861
define :GEM_AFTER_FETCH, "after-fetch"
5962

6063
# @!parse
61-
# A hook called before a git source is fetched.
64+
# A hook called before a git source is fetched or checked out.
6265
# Includes a Bundler::Source::Git reference.
6366
# GIT_BEFORE_FETCH = "before-git-fetch"
6467
define :GIT_BEFORE_FETCH, "before-git-fetch"
6568

6669
# @!parse
67-
# A hook called after a git source is fetched.
70+
# A hook called after a git source is fetched or checked out.
6871
# Includes a Bundler::Source::Git reference.
6972
# GIT_AFTER_FETCH = "after-git-fetch"
7073
define :GIT_AFTER_FETCH, "after-git-fetch"
7174

7275
# @!parse
73-
# A hook called before any gems install
74-
# Includes an Array of Bundler::Dependency objects
75-
# GEM_BEFORE_INSTALL_ALL = "before-install-all"
76-
define :GEM_BEFORE_INSTALL_ALL, "before-install-all"
76+
# A hook called before each individual gem is installed
77+
# Includes a Bundler::ParallelInstaller::SpecInstallation.
78+
# No state, error, post_install_message will be present as nothing has installed yet
79+
# GEM_BEFORE_INSTALL = "before-install"
80+
define :GEM_BEFORE_INSTALL, "before-install"
81+
82+
# @!parse
83+
# A hook called after each individual gem is installed
84+
# Includes a Bundler::ParallelInstaller::SpecInstallation.
85+
# - If state is failed, an error will be present.
86+
# - If state is success, a post_install_message may be present.
87+
# GEM_AFTER_INSTALL = "after-install"
88+
define :GEM_AFTER_INSTALL, "after-install"
7789

7890
# @!parse
7991
# A hook called after any gems install
8092
# Includes an Array of Bundler::Dependency objects
8193
# GEM_AFTER_INSTALL_ALL = "after-install-all"
8294
define :GEM_AFTER_INSTALL_ALL, "after-install-all"
8395

96+
# @!parse
97+
# A hook called before any gems require
98+
# Includes an Array of Bundler::Dependency objects.
99+
# GEM_BEFORE_REQUIRE_ALL = "before-require-all"
100+
define :GEM_BEFORE_REQUIRE_ALL, "before-require-all"
101+
84102
# @!parse
85103
# A hook called before each individual gem is required
86104
# Includes a Bundler::Dependency.
@@ -93,29 +111,11 @@ def self.defined_event?(event)
93111
# GEM_AFTER_REQUIRE = "after-require"
94112
define :GEM_AFTER_REQUIRE, "after-require"
95113

96-
# @!parse
97-
# A hook called before any gems require
98-
# Includes an Array of Bundler::Dependency objects.
99-
# GEM_BEFORE_REQUIRE_ALL = "before-require-all"
100-
define :GEM_BEFORE_REQUIRE_ALL, "before-require-all"
101-
102114
# @!parse
103115
# A hook called after all gems required
104116
# Includes an Array of Bundler::Dependency objects.
105117
# GEM_AFTER_REQUIRE_ALL = "after-require-all"
106-
define :GEM_AFTER_REQUIRE_ALL, "after-require-all"
107-
108-
# @!parse
109-
# A hook called before the Gemfile is evaluated
110-
# Includes the Gemfile path and the Lockfile path
111-
# GEM_BEFORE_EVAL = "before-eval"
112-
define :GEM_BEFORE_EVAL, "before-eval"
113-
114-
# @!parse
115-
# A hook called after the Gemfile is evaluated
116-
# Includes a Bundler::Definition
117-
# GEM_AFTER_EVAL = "after-eval"
118-
define :GEM_AFTER_EVAL, "after-eval"
118+
define :GEM_AFTER_REQUIRE_ALL, "after-require-all"
119119
end
120120
end
121121
end

0 commit comments

Comments
 (0)