Skip to content

Make sure rubygems/package can be directly required reliably #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Make sure rubygems/package can be directly required reliably #3670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73c199b
Make sure rubygems/package can be directly required reliably
bronzdoc May 31, 2020
5e6d82b
Use ruby_with_rubygems_in_load_path helper
bronzdoc Jun 3, 2020
e6cabc3
Move require to the top
bronzdoc Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/rubygems/package.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
# #files are the files in the .gem tar file, not the Ruby files in the gem
# #extract_files and #contents automatically call #verify

require "rubygems"
require 'rubygems/security'
require 'rubygems/specification'
require 'rubygems/user_interaction'
Expand Down
9 changes: 8 additions & 1 deletion test/rubygems/test_project_sanity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# frozen_string_literal: true

require "rubygems/test_case"
require "open3"

class TestProjectSanity < Minitest::Test
class TestProjectSanity < Gem::TestCase

def test_manifest_is_up_to_date
skip unless File.exist?(File.expand_path("../../../Rakefile", __FILE__))
Expand All @@ -12,4 +13,10 @@ def test_manifest_is_up_to_date
assert status.success?, "Expected Manifest.txt to be up to date, but it's not. Run `rake update_manifest` to sync it."
end

def test_require_rubygems_package
err, status = Open3.capture2e(*ruby_with_rubygems_in_load_path, "--disable-gems", "-e", "'require \"rubygems/package\"'")

assert status.success?, err
end

end