Pass DESTDIR via command line to override what's in MAKEFLAGS. #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an installation problem under a package building environment where DESTDIR is specified in the (parent) command line. Related bug reports: - https://bugzilla.redhat.com/show_bug.cgi?id=921650 - ruby/ruby#327
|
I want to include this patch to CRuby's bundled rubygems in 2.0.0. Can I merge it to CRuby repository? |
|
Yes, go ahead and merge it. I will merge it to RubyGems master shortly. |
|
Great. I'm ready to commit this to ruby trunk, so let me know if you want me to do it. |
|
Thank you for your response! @knu could you commit it to ruby trunk? |
|
Done at r41629. Let's see if it doesn't break anything on the CI. |
drbrain
added a commit
that referenced
this pull request
Jun 26, 2013
Pass DESTDIR via command line to override what's in MAKEFLAGS.
drbrain
added a commit
that referenced
this pull request
Jun 26, 2013
drbrain
added a commit
that referenced
this pull request
Jun 27, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an installation problem under a package building
environment where DESTDIR is specified in the (parent) command line.
Related bug reports: