Skip to content

Conversation

@filbranden
Copy link
Contributor

It was added to toolcache in commit ruby/ruby-builder@9fa2773.

Tested that it works, using both ubuntu-latest and macos-latest:
https://github.com/filbranden/vimgolf/actions/runs/887034477

Fixes #181.

It was added to toolcache in commit 9fa277367b8cd338cfc5aca4b91d854e8e0a58b2.
@eregon
Copy link
Member

eregon commented May 30, 2021

Thanks for the PR, could you also add it in the README (just as 2.0.0), and add 2.0.0 in the CI workflow?

@filbranden
Copy link
Contributor Author

@eregon I updated the PR, pushed a follow up commit updating the README and adding the version to the CI.

My own CI run failed to resolve macos-11.0, not sure why that happened, since the weekly run here worked just fine...
https://github.com/filbranden/setup-ruby/actions/runs/893761034

In any case, doesn't look related to these changes, and the runs on 2.0 all succeeded (with the exception of the macos-11.0 one, so not completely sure whether that one is fine or not.)

Let me know if you need anything else from me on this PR, happy to follow up!

Cheers,
Filipe

@filbranden
Copy link
Contributor Author

Ah! "The macOS 11 virtual environment is currently provided as a private preview only." so that explains it... Anyways, please run it on this PR to confirm it works as expected. Cheers!

@eregon eregon merged commit fd1a6a0 into ruby:master May 31, 2021
@filbranden filbranden deleted the ruby200 branch May 31, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requesting support for Ruby 2.0.0

2 participants