-
-
Notifications
You must be signed in to change notification settings - Fork 342
Windows - updates for mswin builds #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Original PR used a PowerShell module known as vssetup.powershell, which contains quite a bit of functionality. But, running it took anywhere from 14 to 20 sec in one run. Too long. Windows images also contain a utility named vsWhere, which is a compiled exe. It takes around a second to run. Last commit uses it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you and sorry for the review delay
No problem. OSS is just a part of our lives... Do you have any opinion about whether we/I should build the mswin Ruby with OpenSSL 3.0? Microsoft's vcpkg 'system' has updated to 3.0 from 1.1. I've also got all the packages needed to build mswin in the MSP-Greg/setup-msys2-gcc release. Hence, it could be installed by setup-ruby just like the mingw and ucrt archive files. I think I'm aware of most of the repos it would affect, and most already work with OpenSSL 3.0... |
I think all GitHub-hosted runners currently use openssl 1.1, not 3, so probably best to stick to 1.1 while it's the case (unless that's problematic for mswin). |
|
GitHub has announced that Ubuntu 22.04 will be available as a preview image in the near future. I believe it uses OpenSSL 3. I'm running it locally, and building/using Ruby master, even added gcc 12. Also, the current release of Microsoft's vcpkg system 2022.04.12 builds OpenSSL 3, so sometime soon the Actions Windows runners would build an mswin package with 3. |
|
One thing I haven't mentioned. mswin builds use a different set of packages than either mingw or ucrt. In the past, it was kind of a mishmash of sources. Now, microsoft/vcpkg has all the packages needed to build mswin (the bison and ragel utilities from MSYS2 work with mswin). Just last month vcpkg updated OpenSSL from 1.1.1 to 3.0 (diff). So, a new installation of vcpkg builds OpenSSL 3.0.2. Packages from vcpkg can be 'exported', so I've also got an archive file of all the packages needed to build mswin. |
|
Sounds good. Yeah then it sound like using vcpkg packages is the best for |
Updates for mswin builds, no 'bugs' involved. Commit info: