Skip to content

Conversation

@trinistr
Copy link
Contributor

@trinistr trinistr commented Nov 20, 2025

Continuing from #1297


More weird stuff:

@trinistr trinistr force-pushed the add-io-buffer-constructors-specs branch 4 times, most recently from 8c9fea2 to fb299b4 Compare November 20, 2025 15:45
@trinistr trinistr force-pushed the add-io-buffer-constructors-specs branch from fb299b4 to 60c35d9 Compare November 20, 2025 18:36
@eregon
Copy link
Member

eregon commented Nov 20, 2025

@ioquatix Could you review this maybe?

@trinistr
Copy link
Contributor Author

@ioquatix Could you review this maybe?

This is still a very early draft, but that offset parameter made me create an issue and a PR to ruby directly, so, yeah 🥹 Reviewing the PR with fixes for the method is probably more useful currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants