Remove usage of IO#nread #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IO#wait, a method to obtain the number of bytes readable without blocking, has been removed from io/wait. ruby/io-wait@1decadc When WEBrick is combined with io.wait >= 0.4.0, the following error occurs on shutdown: ERROR NoMethodError: undefined method 'nread' for an instance of IO /(snip)/webrick-1.9.1/lib/webrick/server.rb:178:in 'block in WEBrick::GenericServer#start' WEBrick uses IO#nread to efficiently consume the entire input stream during shutdown. This patch removes the call to IO#nread, and instead repeatedly take a fixed size of 8 bytes each iteration.
Contributor
Author
|
Tests now pass on my laptop. |
Member
|
👍 Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #179.
IO#wait, a method to obtain the number of bytes readable without blocking, has been removed from io/wait.
ruby/io-wait@1decadc
When WEBrick is combined with io.wait >= 0.4.0, the following error occurs on shutdown:
WEBrick uses IO#nread to efficiently consume the entire input stream during shutdown. This patch removes the call to IO#nread, and instead repeatedly take a fixed size of 8 bytes each iteration.