Skip to content

Conversation

@corsonknowles
Copy link
Contributor

@corsonknowles corsonknowles commented Nov 19, 2025

  1. Consistent magic comments
    a. frozen_string_literal throughout
    b. Remove Sorbet comments
  2. Consistent require statements
    a. Remove spec_helper require statements that are covered by the .rspec file's declaration
    b. Remove all other require statements that do not affect their specs
  3. Add a reminder comment about EOL date for the CI matrix (although this is most likely best changed when the newest Ruby is added in Jan)
  4. Very minor readme formatting changes

- '3.4'
- '3.3'
- '3.2'
- '3.2' # EOL: 2026-03-31 (expected)
Copy link
Contributor Author

@corsonknowles corsonknowles Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem if you don't want this, I just always go to check these are current when I see a testing matrix

@corsonknowles corsonknowles marked this pull request as ready for review November 19, 2025 22:23
@corsonknowles corsonknowles changed the title Very minor cleanup and comments Copy edits Nov 21, 2025
@martinemde martinemde merged commit f9f28c0 into rubyatscale:main Nov 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants