Skip to content

Update the homepage featured elements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2023
Merged

Update the homepage featured elements #2

merged 1 commit into from
Jan 25, 2023

Conversation

@adarsh
Copy link
Contributor

@adarsh adarsh commented Jan 25, 2023

Reason for Change

  • Some items on the blog site were outdated and needed to be removed.
  • I realized some things can be managed automatically by "featuring" posts. This logic already existed so I removed the hardcoded bits.

Changes

  • Remove rubyconf home edition section on the homepage
  • Remove link to news. We have a menu nav item for that, it should be enough.
  • In the CSS, I renamed next-conf to homepage-featured.
  • Increase limit of featured posts to 3 from 1

Minor

  • Updated the README.md instructions as I went along.
  • Updated some instructions in our Company Manual

@adarsh
Update the homepage featured elements
5762c65 
Reason for Change
=================
* Some items on the blog site were outdated and needed to be removed.
* I realized some things can be managed automatically by "featuring" posts. This logic already existed so I removed the hardcoded bits.

Changes
=======
* Remove rubyconf home edition section on the homepage
* Remove link to news. We have a menu nav item for that, it should be enough.
* In the CSS, I renamed `next-conf` to `homepage-featured`.
* Increase limit of featured posts to 3 from 1

Minor
=====
* Updated the `README.md` instructions as I went along.
* Updated some instructions in our [Company Manual]

[Company Manual]: https://docs.google.com/document/d/1MPd4CSCmuVj0YqtZmhWuIZGFr4lagU6iNYu_wpeCMO0/edit#
indirect
indirect approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! you could potentially manage a featured post and an upcoming conference separately using tags, but this seems like an easy way to handle it for now 👍🏻

@adarsh
Copy link
Contributor Author

adarsh commented Jan 25, 2023

looks good! you could potentially manage a featured post and an upcoming conference separately using tags, but this seems like an easy way to handle it for now 👍🏻

Yeah I agree. I'll make a note to do this in the future.

@adarsh adarsh mentioned this pull request Jan 25, 2023
Open
@adarsh adarsh merged commit 5762c65 into main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@indirect indirect indirect approved these changes

@devonharless devonharless Awaiting requested review from devonharless

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adarsh @indirect