Enable subclasses overriding namespace root key #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhnaranjo
commented
Feb 21, 2024
lib/superform/rails.rb
Outdated
| @method.to_s.downcase == "get" ? "get" : "post" | ||
| end | ||
|
|
||
| def namespace_root_key |
Contributor
Author
There was a problem hiding this comment.
Or maybe just param_key?
dhnaranjo
force-pushed
the
custom_form_namespace
branch
from
0a70cec to
67dfb66
Compare
Contributor
|
This is looking good! Docs are 🔥 🔥 If you can squash these I'll merge into main and cut a new gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yowhattup. Following up on my question in Discord. Howsabout we let subclasses set their own namespace root keys?