Skip to content

Conversation

@adrianlyjak
Copy link
Collaborator

No description provided.

@adrianlyjak adrianlyjak marked this pull request as ready for review August 7, 2025 16:43
...(platformToken && { authorization: `Bearer ${platformToken}` }),
// This header is required for requests to correctly scope to the agent's project
// when authenticating with a user cookie
...(projectId && { "Project-Id": projectId }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can integrate the whole auth into our sdk as well.
And we only expose some configurations out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "the whole auth?" Like, making the typescript sdk support reading the miscellaneous variables and configure its client automatically? Agree, that would be nice. It's a little awkward with the prefixed env vars

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@adrianlyjak adrianlyjak merged commit a46c002 into main Aug 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants