feat(devbox): added devbox.shell(shellName) command and stateful shell class to SDK#665
feat(devbox): added devbox.shell(shellName) command and stateful shell class to SDK#665
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI finished reviewing your PR. |
✅ Object Smoke Tests & Coverage ReportTest Results✅ All smoke tests passed Coverage Results
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests) ✅ All tests passed and all object methods are covered! View detailed coverage reportCoverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%. |
jrvb-rl
left a comment
There was a problem hiding this comment.
Overall this looks good. We should think a bit about what guarantees we want to make for this primitive.
Also, I didn't notice the command queuing / serialization here. Is that something that already happens on the server side for named shells?
| * | ||
| * Named shells are stateful and maintain environment variables and the current working directory (CWD) | ||
| * across commands, just like a real shell on your local computer. Commands executed through the same | ||
| * named shell instance will execute sequentially - the shell can only run one command at a time with |
There was a problem hiding this comment.
What happens if the user does
shell.exec("long_running_thing &")
shell.exec("BG_PID=$!")
My personal take is that we should not promise a long running bash shell, so we should make no guarantees about any shell-specific features or syntax. So maybe explicitly say that the only thing we are guaranteeing will persist are the values in 'env' output and the CWD?
If we want to be a bit more specific, we could say:
"Persistent shells will run in a bash shell, with the same CWD and env. Commands may not all run in the exact same shell process, so more exotic bash shell features may work in some cases."
There was a problem hiding this comment.
yah so Jon wrote a whole queuing thing, so this should work just fine. So only one will run at a time. I will update it not to say like a real shell.
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI Incremental review completed. |
|
| Metric | Coverage | Required | Status |
|---|---|---|---|
| Functions | 98.24% | 100% | ❌ |
| Lines | 85.48% | - | ℹ️ |
| Branches | 51.54% | - | ℹ️ |
| Statements | 85.03% | - | ℹ️ |
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)
View detailed coverage report
Coverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%.
✅ Object Smoke Tests & Coverage ReportTest Results✅ All smoke tests passed Coverage Results
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests) ✅ All tests passed and all object methods are covered! View detailed coverage reportCoverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%. |
CodeAnt-AI Description
Add stateful named shell sessions to Devbox
What Changed
Impact
✅ Stateful shell sessions keep env and CWD across commands✅ Sequential command execution avoids overlapping runs in a named shell✅ Streaming callbacks reflect the same output as final results💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.