fix(documentation): added types to the typedoc main list and fixed some decorators#677
fix(documentation): added types to the typedoc main list and fixed some decorators#677
Conversation
…made some changes to fix some rendering issues (eg. added @remarks).
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Nitpicks 🔍
|
|
CodeAnt AI finished reviewing your PR. |
|
| Metric | Coverage | Required | Status |
|---|---|---|---|
| Functions | 95.65% | 100% | ❌ |
| Lines | 83.64% | - | ℹ️ |
| Branches | 45.91% | - | ℹ️ |
| Statements | 82.12% | - | ℹ️ |
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)
View detailed coverage report
Coverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%.
jrvb-rl
left a comment
There was a problem hiding this comment.
I don't think there is an easy way to preview this while doing the review (unlike our docs site...) Based on our conversation earlier, though, this LGTM and seems like a nice improvement.
| "extends": "./tsconfig.json", | ||
| "exclude": ["**/*.test.ts", "**/tests/**", "**/node_modules/**", "src/_shims/**/*-deno.ts"], | ||
| "include": ["src/sdk.ts", "src/sdk/**/*.ts", "src/core.ts", "src/resources/**/*.ts", "src/lib/**/*.ts"] | ||
| "include": ["src/sdk.ts", "src/types.ts", "src/sdk/**/*.ts", "src/core.ts", "src/resources/**/*.ts", "src/lib/**/*.ts"] |
There was a problem hiding this comment.
Does the order here dictate the order of the left navbar? If so, maybe put the 'types.ts' first?
There was a problem hiding this comment.
Apparently not, since types shows up after SDK.
The auto-review tool caught 2 potential issues:
- the
@categorytag shows up on generated resources, so i'm going to submit a PR for the java side to produce these tags types.tsshould be named as an excluded type so it only gets used during doc generation.
The other messages are wrong (this is valid syntax in this version of ts).
I'm making the ts-side change now and will test it out before pushing & merging
There was a problem hiding this comment.
I made the types change. I'm unsure as to whether the category will be persisted -- I think stainless might preserve it anyway. I'm going to try merging this change and i'll be vigilant about making a followup if something breaks.
|
| Metric | Coverage | Required | Status |
|---|---|---|---|
| Functions | 95.65% | 100% | ❌ |
| Lines | 83.64% | - | ℹ️ |
| Branches | 45.91% | - | ℹ️ |
| Statements | 82.12% | - | ℹ️ |
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)
View detailed coverage report
Coverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%.
User description
Description
@remarksto fix some issuestypes.tsto rexport types for the typedocs to work correctlyMotivation
Changes
Testing
Breaking Changes
Checklist
feat:orfeat(scope):)CodeAnt-AI Description
Include centralized type exports and categorize SDK types for Typedoc
What Changed
Impact
✅ Find raw API types in docs✅ Clearer documentation categories for SDK operations✅ Easier discovery of resource and SDK types💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.