Merged
Conversation
The deprecated createTunnel endpoint now creates v2 tunnels which cannot be removed. Updated the test to: - Remove the tunnel removal attempt that was causing 400 errors - Add verification that the tunnel persists in devbox info - Update test name and comments to reflect v2 tunnel behavior Co-authored-by: albert <alb-rl@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
| Metric | Coverage | Required | Status |
|---|---|---|---|
| Functions | 99.52% | 100% | ❌ |
| Lines | 88.85% | - | ℹ️ |
| Branches | 65.75% | - | ℹ️ |
| Statements | 87.51% | - | ℹ️ |
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)
View detailed coverage report
| File | Functions | Lines | Branches |
|---|---|---|---|
| src/sdk.ts | ✅ 100% | 85.11% | 70.83% |
| src/sdk/agent.ts | ✅ 100% | 100% | 100% |
| src/sdk/blueprint.ts | ✅ 100% | 100% | 80% |
| src/sdk/devbox.ts | ❌ 97.5% | 90.9% | 96.96% |
| src/sdk/execution-result.ts | ✅ 100% | 92.68% | 70.83% |
| src/sdk/execution.ts | ✅ 100% | 94.11% | 83.33% |
| src/sdk/gateway-config.ts | ✅ 100% | 100% | 100% |
| src/sdk/mcp-config.ts | ✅ 100% | 100% | 100% |
| src/sdk/network-policy.ts | ✅ 100% | 100% | 100% |
| src/sdk/scenario-run.ts | ✅ 100% | 96.87% | 50% |
| src/sdk/scenario.ts | ✅ 100% | 100% | 100% |
| src/sdk/scorer.ts | ✅ 100% | 100% | 100% |
| src/sdk/snapshot.ts | ✅ 100% | 100% | 100% |
| src/sdk/storage-object.ts | ✅ 100% | 80% | 48.93% |
tode-rl
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format:
feat[optional scope]: <description>Examples:
feat: add new SDK method·feat(storage): support file uploads·feat!: breaking API changeDescription
Updates a smoketest for the deprecated
create_tunnelendpoint to reflect its current behavior, where it now creates unremovable v2 tunnels.Motivation
The
create_tunnelendpoint, though deprecated, was updated to create v2 Portal tunnels which cannot be removed. The existing smoketest was failing because it attempted to remove these tunnels, resulting in a 400 error. This PR updates the test to correctly validate the new behavior.Changes
devbox.net.removeTunnelcall from the test.Testing
Breaking Changes
None.
Checklist
feat:orfeat(scope):)Slack Thread