Simplify right-hand side of claims #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d605fcd8e90549253aae40309bcdb51e6172c9b.
…part2' into simplify-rhs-of-claims
2 tasks
ttuegel
reviewed
Aug 25, 2020
kore/src/Kore/Strategies/Goal.hs
Outdated
| (lensClaimPattern . field @"right") | ||
| (OrPattern.flatten simplifiedDestination) | ||
| goal | ||
| simplifyLeftHandSide goal' |
There was a problem hiding this comment.
Shouldn't we simplify the left-hand side first? We want the condition on the left-hand side to be fully simplified before we use it as a SideCondition. Also, we might be able to remove some branches, in which case it isn't necessary to simplify the right-hand side.
Co-authored-by: Thomas Tuegel <ttuegel@mailbox.org>
… into simplify-rhs-of-claims
ttuegel
approved these changes
Aug 25, 2020
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1278
After #2025
Reviewer checklist
stack test --coveragestack haddock