Set up K-style versioning #3924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
requested review from
geo2a,
goodlyrottenapple,
jberthold and
tothtamas28
Contributor
goodlyrottenapple
left a comment
goodlyrottenapple
left a comment
There was a problem hiding this comment.
LGTM but let's wait till monday for @jberthold and @geo2a to have a look
jberthold
reviewed
Jun 8, 2024
jberthold
requested changes
Jun 8, 2024
Contributor
Author
|
Note that the policy implemented here in response to @jberthold's comments is that we shouldn't cut a release if the Cabal / Stack caching steps fail. |
rv-jenkins
pushed a commit
that referenced
this pull request
Jun 11, 2024
Fixes an oversight in the job dependency changes of #3924 I also pushed a branch named `release` to github to make the `version-bump` job work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a release versioning scheme that's a carbon copy of the setup used in the LLVM backend, but with development happening on the
masterbranch and versioning information being carried on thereleasebranch.The code is well-tested on the LLVM backend side, and I've tested the various versioning scripts locally, but it's difficult to explicitly test the end-end integration here without just merging the PR. Any remaining bugs or issues will be easy to iron out once we've seen a run happen here.