-
Notifications
You must be signed in to change notification settings - Fork 43
Add timestampts to JSON logs #3925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| isEmpty DebugAppliedRewriteRules{appliedRewriteRules} | ||
| | null appliedRewriteRules = True | ||
| | otherwise = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is now no way (I think) to filter the message once we already start converting it to LogStr, so we would either have to render it twice, once in the filter (where we could then check if it is empty/null) and second time when we actually want to log it. As this would be inefficient, I've added a type-class function which can be used to control if some kore Entry is just used for context and should thus not be emitted as a message. See occurrences of isEmpty in this PR to see what I mean.
geo2a
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I've played around with both booster-dev and kore-rpc-booster and the logging options. The JSON timestamp work as I'd expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (haven't tested it, though) tested now
|
While at it, could you please remove the dot from https://github.com/runtimeverification/haskell-backend/pull/3925/files#diff-fdf134fb9c13c1143cd1c9d16f037c810a3f29d61d40c9944b898af886bb61e9R188 so that we can parse the timestamps later? The |
Fixes #3894