Skip to content

Fix release CI job #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix release CI job #3933

merged 1 commit into from
Jun 11, 2024

Conversation

@goodlyrottenapple
Copy link
Contributor

@goodlyrottenapple goodlyrottenapple commented Jun 11, 2024

looks like we maybe need to explicitly add draft-release to the needs section of update-depends??

@goodlyrottenapple
Fix release CI job
7df5959 
looks like we maybe need to explicitly add `draft-release` to the needs section of `update-depends`??
@goodlyrottenapple goodlyrottenapple merged commit 3b01114 into master Jun 11, 2024
@goodlyrottenapple goodlyrottenapple deleted the sam/HOTFIX-needs-draft-release branch June 11, 2024 14:44
@jberthold
Copy link
Member

jberthold commented Jun 11, 2024

looks like we maybe need to explicitly add draft-release to the needs section of update-depends??

Yes, thanks - I missed that detail in the rush to fix things.
Another question is why we actually build that release again - we have tested building with both cabal and stack in master. What would make sense if we want to do it is to re-run the integration tests before publishing the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goodlyrottenapple @jberthold