Skip to content

Conversation

@jberthold
Copy link
Member

When a constraint of shape VAR:VarSort ~> .K ==K term:TermSort ~> .K is externalised, the prior code just rendered a VAR:VarSort #Equals term:TermSort. This is wrong when TermSort /= VarSort, however TermSort will be a subsort of VarSort, otherwise the rule that introduced this ==K term is ill-sorted.

  • Externalisation code now inserts the missing injection into the #Equals expression.
  • A test was added which demonstrates the use case and behaviour (failed before, succeeds now).
  • A pretty-printer option was added to show the injections in the printed terms (off by default).

@jberthold jberthold requested review from PetarMax and geo2a November 26, 2024 08:28
Co-authored-by: Petar Maksimović <PetarMax@users.noreply.github.com>
@rv-jenkins rv-jenkins merged commit 26d79cb into master Nov 27, 2024
6 checks passed
@rv-jenkins rv-jenkins deleted the HOTFIX-subsort-k-equals-issue branch November 27, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants