Kompile uses new type inference algorithm #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
approved these changes
Dec 11, 2023
Contributor
Baltoli
left a comment
Baltoli
left a comment
There was a problem hiding this comment.
Looks good; when runtimeverification/pyk#767 is finalised and merged you should be able to use the new feature directly via Pyk.
Baltoli
suggested changes
Dec 11, 2023
Contributor
Baltoli
left a comment
Baltoli
left a comment
There was a problem hiding this comment.
Ah, in fact it doesn't look like this is in fact supported via kbuild.toml. Probably best to wait and use the Pyk feature I linked above.
Contributor
|
I am popping this up since the type-inference feature is supported by pyk by PR runtimeverification/pyk#767. |
Collaborator
Author
|
Created an issue here |
dkcumming
force-pushed
the
feature/new-type-inf
branch
from
fa5ae5c to
3ee298e
Compare
Collaborator
Author
Baltoli
approved these changes
Jan 12, 2024
Contributor
Baltoli
left a comment
Baltoli
left a comment
There was a problem hiding this comment.
Looks good to me! Timing probably won't be hugely different I suspect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new type inference algorithm has been introduced to K. This PR opts into using that algorithm by setting the appropriate flags in
kbuild.toml