Extract SMIR kompilation into module kmir.kompile
#751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
approved these changes
Oct 18, 2025
| _LOGGER.info(f'Copying file {file}') | ||
| shutil.copy2(LLVM_DEF_DIR / file, target_llvm_path / file) | ||
| return KMIR(target_llvm_path, None, bug_report=bug_report) | ||
| from .kompile import kompile_smir |
Member
There was a problem hiding this comment.
This creates an import loop (however only in local scope), that's why I didn't continue with factoring out the compilation code. If that's not a problem I have no objections.
| from pyk.kast.prelude.string import stringToken | ||
|
|
||
| from .build import HASKELL_DEF_DIR, LLVM_DEF_DIR, LLVM_LIB_DIR | ||
| from .kmir import KMIR |
Member
There was a problem hiding this comment.
Here is the loop. In theory we could call KMIR.from_kompiled_kore in this module, which imports the module again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.